Skip to content

lib: apply minor dtls cleanups#63539

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/dtls-cleanup
Open

lib: apply minor dtls cleanups#63539
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/dtls-cleanup

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented May 24, 2026

Remove the object seal on the exports.

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added dtls needs-ci PRs that need a full CI run. labels May 24, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.32%. Comparing base (c9562dd) to head (f9c3ada).
⚠️ Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63539      +/-   ##
==========================================
+ Coverage   90.30%   90.32%   +0.02%     
==========================================
  Files         730      730              
  Lines      234188   234152      -36     
  Branches    43919    43909      -10     
==========================================
+ Hits       211478   211500      +22     
+ Misses      14443    14372      -71     
- Partials     8267     8280      +13     

see 39 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label May 31, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 31, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/63539
βœ”  Done loading data for nodejs/node/pull/63539
----------------------------------- PR info ------------------------------------
Title      lib: apply minor dtls cleanups (#63539)
Author     James M Snell <jasnell@gmail.com> (@jasnell)
Branch     jasnell:jasnell/dtls-cleanup -> nodejs:main
Labels     author ready, needs-ci, dtls
Commits    1
 - lib: apply minor dtls cleanups
Committers 1
 - James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63539
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63539
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Sun, 24 May 2026 14:42:31 GMT
   βœ”  Approvals: 1
   βœ”  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63539#pullrequestreview-4353037573
   ✘  This PR needs to wait 6 more hours to land (or 0 minutes if there is one more approval)
   βœ”  Last GitHub CI successful
   β„Ή  Last Full PR CI on 2026-05-25T02:08:33Z: https://ci.nodejs.org/job/node-test-pull-request/73686/
- Querying data for job/node-test-pull-request/73686/
βœ”  Build data downloaded
   βœ”  Last Jenkins CI successful
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/26708502888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dtls needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants